Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: check all drivers on node #6227

Merged
merged 2 commits into from
Aug 29, 2019
Merged

schedulers: check all drivers on node #6227

merged 2 commits into from
Aug 29, 2019

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Aug 29, 2019

When checking driver feasability for an alloc with multiple drivers, we
must check that all drivers are detected and healthy.

Nomad 0.9 and 0.8 have a bug where we may check a single driver only,
but which driver is dependent on map traversal order, which is
unspecified in golang spec.

Mahmood Ali added 2 commits August 29, 2019 09:03
When checking driver feasability for an alloc with multiple drivers, we
must check that all drivers are detected and healthy.

Nomad 0.9 and 0.8 have a bug where we may check a single driver only,
but which driver is dependent on map traversal order, which is
unspecified in golang spec.
Copy link
Contributor

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof.

Result bool
}{
{
Node: nodes[0],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name the tests or comment the case they cover for easier future reading?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do as a part of a rewrite when we drop compatibility path.

@notnoop notnoop merged commit 4320d87 into master Aug 29, 2019
@notnoop notnoop deleted the b-drivers-check branch August 29, 2019 13:48
@tantra35
Copy link
Contributor

tantra35 commented Sep 9, 2019

@notnoop If i understand all correctly this fix #5485 ?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants